Fix costs dict key and num_reps in driver_coal#103
Closed
ylu283 wants to merge 1 commit into
Closed
Conversation
- costs extraction used var.name instead of exp.name for Expression objects - num_reps was 5, should be 4 to match seasonal representative periods
Member
|
This is an old and untested driver that we don't intend to support so going to close this. Eventually the plan is to remove this file completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes in driver_coal.py:
var.nameinstead ofexp.namewhen iterating Expression objects, causing all entries to map to the last Disjunct variable namenum_repswas 5, should be 4 to match the 4 seasonal representative periods